Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folded blocks are indicated by >, not by the chomping indicator #28

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Folded blocks are indicated by >, not by the chomping indicator #28

merged 1 commit into from
Jan 29, 2025

Conversation

FichteFoll
Copy link
Member

Fixes a regression from #22.

Took me a while to

  1. notice this
  2. become annoyed enough to look into a fix
  3. actually fix it (this step was trivial)

@FichteFoll FichteFoll added the bug Something isn't working label Jan 29, 2025
@FichteFoll
Copy link
Member Author

FichteFoll commented Jan 29, 2025 •
edited
Loading

Note that the syntax tests don't pass for current master Packages branch because of the many changes to the ShellScript syntax. (see #29)

@FichteFoll FichteFoll mentioned this pull request Jan 29, 2025
Open
@FichteFoll FichteFoll requested a review from keith-hall January 29, 2025 13:22
keith-hall
keith-hall approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@keith-hall keith-hall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@keith-hall keith-hall merged commit 0748e58 into master Jan 29, 2025
4 checks passed
@FichteFoll FichteFoll deleted the bugfix/folding-block branch January 30, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-hall keith-hall keith-hall approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FichteFoll @keith-hall