Be paranoid about clearing media before copying when exporting #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohare93
approved these changes
Sep 15, 2024
crowd_anki/export/anki_exporter.py
Outdated
| elsewhere. | ||
|
|
||
| """ | ||
| unsafe_dirs = [Path.home()] |
There was a problem hiding this comment.
Why end the paranoia there? 😁 include '/' and '' too!
There was a problem hiding this comment.
Thanks so much for reviewing/approving! :)
That was the initial version, but had thought that if somebody is using Anki as root then either:
- they're running in docker, for testing (?), so likely don't have anything too valuable at "/"
- they like living on the edge, so I don't want to spoil their experience. :)
(Unlike HOME it also doesn't help on Windows, where I have no idea what the appropriate paths would be.)
OTOH it doesn't hurt, so I've added it back in! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
#212 (comment)