fix(deps): better-sqlite3 12.11.1 for node 26 compile - #14
Merged
Conversation
node 26 removed info.This() from V8 property callbacks; 12.6.2 fails to compile from source, breaking the brew formula (builds against brew node, now 26.x) and any npm install on node 26. 12.11.1 declares engine support through 26.x. full suite verified green on node 26.5.0. allowScripts grant added by npm approve-scripts rides along so gated installers can run the native build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew upgrade to 3.0.0 failed: brew's node moved to 26, and better-sqlite3 12.6.2 doesn't compile there (V8 dropped
info.This()on property callbacks). the^12.6.2range already allowed newer, the lockfile was pinning the broken version.gate note: dependency bump, no behavior change; suite + on-target node 26 compile check are the gates.