Fix desync on netplay start #193
Open
+4
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think I want to merge this for now without it having been tested, but I'll look into it if I ever come back to this. The memsets by themselves are fine but I'm not sure about the other lines that were removed. At least, I couldn't say for sure without testing it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed random inputs on netplay start when implementing GameYob's multiplayer into Cave Story DS, and this commit should fix it.
Unfortunately I can't test this as I don't have two flashcarts, but I can confirm that this did fix the desync problems I was having during early multiplayer testing.
There are a few more improvements I'd like to push as well (same frame delay on client and host, don't disconnect when packets aren't received, set SRAM transfer packet to require acknowledge), but I think this is ok for now.