Fix tests and remove unused import for #675, #673, #672, #690, #693#744
Merged
Jayy4rl merged 1 commit intoJun 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tests, remove dead code, and clean up mock patterns
Closes #669
Closes #691
Description:
GET /api/v1/admin/vaults/archivedendpoint #675): Remove unusedimport * as vault; refactor mocks to usevi.mocked(VaultService).mockReturnValue(...)pattern for consistency.GET /api/v1/admin/consistency/total-supply#673): Same mock refactoring � replacenew VaultService()notifications.jsmock withvalidateWebhookUrl;include
consecutiveFailuresfield in expected response.child: vi.fn().mockReturnThis()to logger mock.beforeEachto beasync; replacerequirewithawait import; rework "logs error on every tick" test to resetlastLedgereach iteration.handleOperatorAdded/handleOperatorRemovedmethods (duplicatesof the implementations at lines 887�945 that accept
ParsedOperatorAddedEvent).calls (
xdr.ScAddressinstead ofxdr.Address,UInt128Partsconstructor); align mockcall order with actual
processEventflow (duplicate check first); update assertion fromDO NOTHINGtoDO UPDATE.