test: add fee-recipient compromise response runbook (closes #87) - #154
Open
Degentle12 wants to merge 3 commits into
Open
test: add fee-recipient compromise response runbook (closes #87)#154Degentle12 wants to merge 3 commits into
Degentle12 wants to merge 3 commits into
Conversation
…ps#87) Adds `test_fee_recipient_compromise_response_runbook` which validates the full admin-key-compromise recovery sequence: 1. Assert unauthorized set_fee_recipient panics (StellarTips#11) 2. Pause → rotate admin → restore fee recipient → unpause 3. Verify next tip routes fee to the safe address Cross-referenced from docs/ADMIN_RUNBOOK.md fire-drill section.
…and remove misleading comment in test CHANGELOG.md: Move test_fee_recipient_compromise_response_runbook entry from ### Added to ### Fixed to match the convention used by all other issue-related entries (Issue StellarTips#38, StellarTips#19, StellarTips#18, StellarTips#17, StellarTips#20). src/test.rs: Remove misleading comment claiming 'The old admin can no longer authorize admin calls' when the code actually tested the new admin's capabilities. Also remove the redundant intermediate rando fee-recipient assignment since Step 4 immediately restores the correct recipient anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #87 — Fee-recipient compromise adversarial test scenario.
Changes
test_fee_recipient_compromise_response_runbooktosrc/test.rsset_fee_recipientpanics with#11(NotAuthorized)docs/ADMIN_RUNBOOK.mdin the fire-drill sectionFiles Changed
src/test.rs— +82 lines (new test)docs/ADMIN_RUNBOOK.md— +1 line (test reference)CHANGELOG.md— +2 lines (entry)