feat: investor list endpoint returns commitments for funded invoice - #215
Open
Stephan-Thomas wants to merge 1 commit into
Open
feat: investor list endpoint returns commitments for funded invoice#215Stephan-Thomas wants to merge 1 commit into
Stephan-Thomas wants to merge 1 commit into
Conversation
|
@Stephan-Thomas Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #180
Type of Change
Checklist
feat:,fix:,chore:, etc.) — enforced by CI.env, or credentials committed (seeCONTRIBUTING.md)Testing
Added an integration test covering the investor list endpoint for a funded invoice. The test seeds multiple investor commitments and verifies that the endpoint returns all commitments with the expected wallet, amount, share percentage, and commitment timestamp. It also verifies that share percentages sum to 100% and that unauthorized sellers cannot access another seller's investor list.
How to Test
403 Forbidden.Test Coverage
Screenshots (if applicable)
Not applicable — this PR adds backend integration test coverage only.
Additional Notes
The test specifically validates the response shape and investor ownership authorization to prevent regressions where commitments are missing, incorrectly calculated, or exposed to unauthorized sellers.
For Reviewers