🔊 Audio-Feedback | Optional Sound Effect Cues for Transaction Events - #670
Merged
Sadeequ merged 1 commit intoAug 2, 2026
Merged
Conversation
Adds a lazily-initialized Web Audio API hook that synthesizes success, warning, and failure chimes with no external audio assets. Wires success/failure playback into ToastQueue on confirmed/failed status transitions, and adds a Sound Effects toggle (off by default) to Settings that persists to localStorage.
|
@milah-247 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useTransactionAudio(src/hooks/useTransactionAudio.ts), a hook that synthesizes success, warning, and failure chimes with the Web Audio API — no external audio files, so nothing to load over the network.AudioContextis created lazily on first play (never at mount) and reused, respecting the browser's autoplay/gesture policy.ToastQueueon the existingconfirmed/failedtoast status transitions (swap confirmed, transaction failed, etc.), tracked as a side effect (not insidesetState) so it's safe under React strict mode.localStorage(sf_audio_enabled).icon-volume-2symbol to the shared SVG sprite for the new toggle row.Technical Requirements Addressed
Files Changed
src/hooks/useTransactionAudio.ts(new)src/components/ui/ToastQueue.tsxsrc/app/settings/page.tsxsrc/components/icons/iconIds.tspublic/sprite.svg,public/static/sprite.svgTesting
npx tsc --noEmit— no new type errors introduced.npx eslinton all changed files — clean.Closes #627