Skip to content

ci: run Soroban contract tests in CI as a quality gate - #1075

Merged
ayomideadeniran merged 2 commits into
StellarDevHub:mainfrom
Horlarmmy:feat/add-contract-test-ci
Aug 3, 2026
Merged

ci: run Soroban contract tests in CI as a quality gate#1075
ayomideadeniran merged 2 commits into
StellarDevHub:mainfrom
Horlarmmy:feat/add-contract-test-ci

Conversation

@Horlarmmy

@Horlarmmy Horlarmmy commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds contract testing to CI as a required quality gate. Previously the
contracts job only ran cargo fmt --check, cargo clippy, and cargo build, so behavioral regressions could slip through to main.

The job (renamed Contracts Build & Test) now also runs the full Soroban
workspace test suite and fails the pull-request workflow on any failure.

Closes #886

Changes

  • .github/workflows/ci.yml
    • Add a Test step running cargo test -- --nocapture
    • Set RUST_BACKTRACE=1 and CARGO_TERM_COLOR=always for clear,
      deterministic failure output
    • No continue-on-error / || true — test failures fail the job
    • Existing rustfmt, clippy, build, and Swatinem/rust-cache steps
      remain unchanged
  • docs/governance/CONTRIBUTING.md
    • Add a "Local Verification" section so contributors can run the exact
      same commands before opening a PR

Local verification

cd contracts
cargo fmt --check
cargo clippy
cargo build
cargo test
Verified: cargo test -- --nocapture passes on a clean environment
(255 tests, 0 failures).
Acceptance criteria
- Contract test failures fail the pull-request workflow
- Command runs successfully on a clean GitHub-hosted runner
- Existing build, formatting, and Clippy checks remain intact
- CI logs identify the failing package and test (Cargo failures: output)
- Contribution docs contain the matching local verification command

@drips-wave

drips-wave Bot commented Aug 3, 2026

Copy link
Copy Markdown

@Horlarmmy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

@Horlarmmy is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel.

A member of the Team first needs to authorize it.

@ayomideadeniran
ayomideadeniran merged commit 73e1ad6 into StellarDevHub:main Aug 3, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Smart Contracts] Run Soroban contract tests as a required CI quality gate

2 participants