fix: contracts workspace cleanup and README merge marker - #1071
Merged
ayomideadeniran merged 2 commits intoJul 31, 2026
Conversation
- Add missing contract directories (continuous_bonding_curve, dao_governance, fractional_nft_vault, lending_pool, parametric_insurance, zk_proof_verifier, hello_world) to the Cargo workspace members list, sorted alphabetically, and fix the compilation errors surfaced once they were included (outdated soroban-sdk APIs, symbol length limits, type mismatches, borrow errors). - Remove contracts/src/, the 70+ orphaned single-file contract templates that were never part of any workspace crate and caused 70+ compilation errors on their own; drop the now-empty root package and the stale errors.json/errors2.json/errors3.json logs. cargo check now passes cleanly across the whole workspace. - Remove the leftover git merge conflict marker in README.md.
|
@privexlabs is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@privexlabs Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Pr under review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
two pre-existing broken members, did_registry and payment_gateway, that were blocking a clean
cargo checkacross the workspace)
never part of any workspace crate, along with the stale errors.json/errors2.json/errors3.json logs
not committed, .env is git-ignored
Details
parametric_insurance, zk_proof_verifier, hello_world to
[workspace] members, alphabetized the list, anddropped the orphaned root
[package](nothing in the repo depended on it)[workspace]table so they join the outer workspace#[contract], replaced removedenv.invoker()withexplicit
require_auth()params, switchedstorage().get/settostorage().persistent())assert!misuse (error enum passed where a format string was expected), symbol_short!length limits, u32/u64 timestamp mismatches, a borrow-after-move
exists in this SDK version
alloc::string::ToStringimportcargo check --workspace,cargo build --workspace, andcargo fmt --checkall pass cleanVerified
cargo check --workspace— no errorscargo build --workspace— matches CI's build stepcargo fmt --check— no diffs>>>>>>>(not committed)
Closes #944
Closes #943
Closes #942
Closes #940