feat: add balance verification to _release()#56
Merged
Kingsman-99 merged 2 commits intoMay 28, 2026
Merged
Conversation
- Assert contract token balance >= invoice.funded before any transfer - Panics with 'insufficient contract balance' on discrepancy - Add test_release_panics_on_low_balance: drains contract mid-payment, verifies panic All 8 tests pass, clippy clean. Closes Stellar-split#32
|
@marvs8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a contract balance check to
_release()before routing funds to recipients, as described in issue #32.Changes
_release(), calltoken_client.balance(&env.current_contract_address())and assert it is>= invoice.fundedbefore the transfer loop. Panics with"insufficient contract balance"if not.test_release_panics_on_low_balance— pays an invoice partially, drains the contract balance viaTokenClient::transfer, then pays the remainder triggering auto-release, which panics as expected.Acceptance Criteria
_release()"insufficient contract balance"if balance is too lowcargo testpass (8/8)cargo clippypasses with zero warningsCloses #32