feat(autoscaling annotation): add for notebook pods #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test Case after this change (but having both filer and kerberos turned off so that the overwrite does not happen) Starting up an existing notebook It wont appear, but for a new notebook it will (or if the statefulset is deleted) I had thought that it would just see the diff in the It might not be able to apply due to; I think the easiest thing to do here is to advise users to either delete their notebooks to recreate it, or we have a job to delete the statefulsets since the notebook controller will recreate them. |
This was referenced Mar 6, 2025
|
The error seems unrelated to any changes I made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for BTIS-874. Note that we still must fix both kerberos and filer-sidecar since right now they are over-writing annotations.