-
Notifications
You must be signed in to change notification settings - Fork 1
[SRLT-111] 전문가 상세정보를 조회한다 #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
The head ref may contain hidden characters: "SRLT-111-\uC804\uBB38\uAC00-\uC0C1\uC138\uD398\uC774\uC9C0-api"
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
544db48
[SRLT-111] Feat: 전문가 상세정보를 조회한다
SeongHo5356 dd4ed8b
[SRLT-111] Chore: .gitignore을 업데이트한다
SeongHo5356 7c3bf8d
[SRLT-111] Refactor: 사용하지 않는 함수를 정리한다
SeongHo5356 737a4ec
[SRLT-111] Refactor: 필요한 포트는 각 도메인에서 정의해서 사용한다
SeongHo5356 2df31c7
[SRLT-111] Refactor: 응답 dto에서 application 계층의 dto를 활용한다
SeongHo5356 2aa18b2
[SRLT-111] Refactor: 전문가 로딩 전략을 수정한다
SeongHo5356 6f04e26
[SRLT-111] Refactor: 함수 이름을 수정한다
SeongHo5356 4925d38
[SRLT-111] Chore: PR템플릿을 추가한다
SeongHo5356 ca6b3f1
[SRLT-111] Chore: 개발가이드를 최신화한다
SeongHo5356 1f868b3
[SRLT-111] Refactor: 코드래빗 리뷰를 반영한다
SeongHo5356 a0397b0
[SRLT-111] Test: 전문가 조회 테스트를 작성한다
SeongHo5356 3e83880
[SRLT-111] Test: 사용하지 않는 Import 문을 제거한다
SeongHo5356 86fee59
[SRLT-111] Chore: 불필요한 Import 문을 삭제한다
SeongHo5356 6f5335a
[SRLT-111] Refactor: 전문가 조회 로딩/응답 구조를 정리한다
SeongHo5356 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| ## 🚀 Why - 해결하려는 문제가 무엇인가요? | ||
|
|
||
| - `어떤 문제를 해결하고자 하나요?` | ||
|
|
||
| - `어떤 배경이 있었나요?` | ||
|
|
||
| ## ✅ What - 무엇이 변경됐나요? | ||
|
|
||
| - `구현한 기능 요약` | ||
|
|
||
| - `주요 변경사항` | ||
|
|
||
| ## 🛠️ How - 어떻게 해결했나요? | ||
|
|
||
| - `핵심 로직 설명` | ||
|
|
||
| - `예외 사항, 고민 포인트 등` | ||
|
|
||
| ## 🖼️ Attachment | ||
|
|
||
| - `화면 이미지, 결과 캡처 등 첨부` | ||
|
|
||
| ## 💬 기타 코멘트 | ||
|
|
||
| - `리뷰어에게 전하고 싶은 말, 테스트 방법, 주의할 점 등` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,3 +46,4 @@ node_modules/ | |
| dist/ | ||
| *.log | ||
| /docs/ | ||
| /AGENTS.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
src/main/java/starlight/adapter/expert/webapi/dto/ExpertCareerResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package starlight.adapter.expert.webapi.dto; | ||
|
|
||
| import starlight.application.expert.provided.dto.ExpertCareerResult; | ||
|
|
||
| import java.time.LocalDateTime; | ||
|
|
||
| public record ExpertCareerResponse( | ||
| Long id, | ||
|
|
||
| Integer orderIndex, | ||
|
|
||
| String careerTitle, | ||
|
|
||
| String careerExplanation, | ||
|
|
||
| LocalDateTime careerStartedAt, | ||
|
|
||
| LocalDateTime careerEndedAt | ||
| ) { | ||
| public static ExpertCareerResponse from(ExpertCareerResult result) { | ||
| return new ExpertCareerResponse( | ||
| result.id(), | ||
| result.orderIndex(), | ||
| result.careerTitle(), | ||
| result.careerExplanation(), | ||
| result.careerStartedAt(), | ||
| result.careerEndedAt() | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
패키지 경로 떼고 import 하면 좋을 것 같은데 혹시 의도된걸까용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
동일한 이름의 LookupPort가 두 패키지에 있어서 충돌 때문에 FQN을 사용했습니다. 현재 저희팀 컨벤션 상, FQN을 유지하는 방법이 최선일 것 같은데, 네이밍 자체를 변경하는 게 좋을까요 ?
@2ghrms