Add XSS sanitizer middleware to Express instance#877
Merged
Conversation
|
@Biokes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
There was a problem hiding this comment.
Pull request overview
Adds a global XSS sanitization layer to the NestJS/Express request pipeline to sanitize inbound request data before it reaches controllers, addressing Issue #822.
Changes:
- Introduces
xssSanitizerMiddlewareto sanitizereq.body,req.query, andreq.paramsrecursively. - Wires the sanitizer into the Express instance in
src/main.tsafter the JSON/urlencoded body parsers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main.ts | Registers the new sanitizer middleware in the global Express middleware chain. |
| src/common/middleware/xss-sanitizer.middleware.ts | Implements recursive sanitization using the xss library for strings, arrays, and plain objects. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
47
to
51
| const expressInstance = httpAdapter.getInstance(); | ||
| expressInstance.use(expressInstance.json({ limit: maxRequestSize })); | ||
| expressInstance.use(expressInstance.urlencoded({ limit: maxRequestSize, extended: true })); | ||
| expressInstance.use(xssSanitizerMiddleware); | ||
|
|
Contributor
|
@Biokes fix the CI. |
Author
fixed |
Contributor
Contributor
|
@Biokes please fix the CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #822