feat: add basic add_commonlibsf_plugin command

[ThirdEyeSqueegee]

Not sure if linking fmt explicitly is required since everything worked fine without doing that but went ahead and did it anyway

[gottyduke]

Not sure if linking fmt explicitly is required since everything worked fine without doing that but went ahead and did it anyway

Then why doing it? spdlog already has fmt as a dependency, statement is redundant.

Again, I would like to ask you to actually test the code first, this addition has only swapped the add_library call in plugin's CMakeLists.txt with add_commonlibsf_plugin, it has no other integrations in CLib itself. Maybe actually implement the rest of the cmake commands that parses and generates Plugin.h?

---

Since you are adding the cmake command first instead of code, assumes the proper plugin declaration code has been implemented within CLib :

set(options OPTIONAL USE_SIGNATURE_SCANNING)

The options need to extend to all version independence properties.

And this will render #24 getters useless. If the plugins will be using all wrapped up CLib plugin declarations and macros, then user should not be able to view the raw or modify SFSEPlugin_Version directly.

[ThirdEyeSqueegee]

Seems like full integration the way CLibNG does would necessitate getting rid of the submodule approach for consuming the library

[gottyduke]

Seems like full integration the way CLibNG does would necessitate getting rid of the submodule approach for consuming the library

How did you come up with this conclusion? CLibNG could be consumed via submodule just as easily as the vcpkg port approach. Are you trying to replace the current PluginAPI with PluginDeclaration implementation again like this commit?

[ThirdEyeSqueegee]

No that's not what I'm trying to do, I'm just having some trouble testing my changes--just updated the PR, maybe someone can validate