Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Relocation & Utilities #302

Merged

Conversation

shad0wshayd3
Copy link
Contributor

changes:

  • add second template arg to applicable Relocation::write_ funcs for address offset
  • remove AllocTrampoline from stl::write_* funcs, this is bad practice
  • normalize stl::write_* support for structs with std::uintptr_t, REL::ID, REL::Offset, REL::Relocation<std::uintptr_t> static address members

changes:
* add second template arg to applicable `Relocation::write_` funcs for address offset
* remove `AllocTrampoline` from `stl::write_*` funcs, this is bad practice
* normalize `stl::write_*` support for structs with `std::uintptr_t`, `REL::ID`, `REL::Offset`, `REL::Relocation<std::uintptr_t>` static `address` members
@qudix
Copy link
Contributor

qudix commented Nov 17, 2024

I was hoping the stl stuff would be deprioritized in favor of just adding it to Relocation (where applicable)

@shad0wshayd3
Copy link
Contributor Author

shad0wshayd3 commented Nov 19, 2024

So I agree, but I don't think it would be applicable in this case. The write_* helpers aren't really related to REL::Relocation so much as they can accept it. I suppose the functions themselves could be reloaded to live in Relocation.h or the REL namespace (or even the REX namespace), but that's kind of splitting hairs, imo.

@ThirdEyeSqueegee ThirdEyeSqueegee merged commit 417c17a into Starfield-Reverse-Engineering:main Nov 20, 2024
5 checks passed
@shad0wshayd3 shad0wshayd3 deleted the dev-misc branch November 20, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants