Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: misc alpha #296

Merged
merged 8 commits into from
Nov 6, 2024
Merged

feat: misc alpha #296

merged 8 commits into from
Nov 6, 2024

Conversation

qudix
Copy link
Contributor

@qudix qudix commented Nov 5, 2024

No description provided.

@Meridiano
Copy link
Contributor

Meridiano commented Nov 5, 2024 •
edited
Loading

I'm not sure about GetHoursPassedExact, it's gameDaysPassed->value multiplied by 12 but shouldn't it be multiplied by 24 instead? GetHourFromDaysPassed that also returns hours from gameDaysPassed uses 24 as a multiplier in its impl and this is logical.

@qudix
Copy link
Contributor Author

qudix commented Nov 5, 2024

Thanks, didn't notice

@qudix qudix merged commit 4665572 into Starfield-Reverse-Engineering:main Nov 6, 2024
5 checks passed
@qudix qudix deleted the dev/misc-alpha branch November 6, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qudix @Meridiano