Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fmt formatter for REL::Version #279

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

powerof3
Copy link
Contributor

@powerof3 powerof3 commented Oct 1, 2024

No description provided.

@qudix
Copy link
Contributor

qudix commented Oct 1, 2024

I think ThirdEyeSqueegee got the ball rolling to remove fmt for cmake users in #271, I dunno how that is going

@ThirdEyeSqueegee
Copy link
Member

@qudix yeah I'm pretty sure fmt isn't being pulled into the project anymore, we should just be able to nuke the fmt formatters

@powerof3
Copy link
Contributor Author

powerof3 commented Oct 1, 2024

I'm still getting a compile error which this fixes, I'm guessing it's because I use the original spdlog in my project vcpkg?

@qudix
Copy link
Contributor

qudix commented Oct 1, 2024

probably

@ThirdEyeSqueegee
Copy link
Member

@powerof3 yeah if you use the custom port for spdlog in your project it won't pull fmt

@ThirdEyeSqueegee
Copy link
Member

Merging but we should nuke the fmt formatters in the future

@ThirdEyeSqueegee ThirdEyeSqueegee merged commit d136014 into Starfield-Reverse-Engineering:main Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants