Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant Offsets.h includes, use offsets in Misc.cpp #174

Closed
wants to merge 1 commit into from
Closed

fix: remove redundant Offsets.h includes, use offsets in Misc.cpp #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/A/ActorValues.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

#include "RE/B/BSTArray.h"
#include "RE/B/BSTSingleton.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/B/BGSObjectInstance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#pragma once

#include "RE/B/BSTSmartPointer.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
2 changes: 0 additions & 2 deletions CommonLibSF/include/RE/B/BSStringPool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#pragma once

#include "RE/Offsets.h"

namespace RE
{
struct BSStringPool
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/B/BSTEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

#include "RE/B/BSTArray.h"
#include "RE/B/BSTSingleton.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
2 changes: 0 additions & 2 deletions CommonLibSF/include/RE/C/ConsoleLog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#pragma once

#include "RE/Offsets.h"

namespace RE
{
class ConsoleLog
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/E/ExtraDataList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
#include "RE/B/BSIntrusiveRefCounted.h"
#include "RE/B/BSLock.h"
#include "RE/E/ExtraDataTypes.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
2 changes: 0 additions & 2 deletions CommonLibSF/include/RE/M/MemoryManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#pragma once

#include "RE/Offsets.h"

namespace RE
{
class MemoryManager
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/N/NativeFunctionBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#pragma once

#include "RE/I/IFunction.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/R/RegSettingCollection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#pragma once

#include "RE/Offsets.h"
#include "RE/S/Setting.h"
#include "RE/S/SettingCollectionList.h"

Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/RTTI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#pragma once

#include "RE/Offsets.h"
// NOTE: this has not been updated

struct __type_info_node;
Expand Down
2 changes: 0 additions & 2 deletions CommonLibSF/include/RE/S/ScaleformGFxValue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#pragma once

#include "RE/Offsets.h"

namespace RE::Scaleform::GFx
{
class MovieImpl;
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/S/Script.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

#include "RE/B/BSStringT.h"
#include "RE/B/BSTList.h"
#include "RE/Offsets.h"
#include "RE/T/TESForm.h"
#include "RE/T/TESQuest.h"

Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/Starfield.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@
#include "RE/N/NativeFunctionBase.h"
#include "RE/N/NiPoint3.h"
#include "RE/N/NiSmartPointer.h"
#include "RE/Offsets.h"
#include "RE/Offsets_NiRTTI.h"
#include "RE/Offsets_RTTI.h"
#include "RE/Offsets_VTABLE.h"
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/T/TESCellFullyLoadedEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#pragma once

#include "RE/B/BSTEvent.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/T/TESContainerChangedEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#pragma once

#include "RE/B/BSTEvent.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/T/TESDataHandler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#include "RE/B/BSTList.h"
#include "RE/F/FormTypes.h"
#include "RE/N/NiSmartPointer.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/T/TESDeathEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

#include "RE/B/BSTEvent.h"
#include "RE/N/NiSmartPointer.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/T/TESForm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#pragma once

#include "RE/B/BSReflection.h"
#include "RE/Offsets.h"
#include "RE/T/TESFile.h"
#include "RE/T/TESFormRefCount.h"

Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/include/RE/T/TESObjectLoadedEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#pragma once

#include "RE/B/BSTEvent.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
2 changes: 0 additions & 2 deletions CommonLibSF/include/RE/U/UI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#pragma once

#include "RE/Offsets.h"

namespace RE
{
class IMenu;
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/src/RE/A/Actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include "RE/A/Actor.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/src/RE/A/ActorEquipManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include "RE/A/ActorEquipManager.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/src/RE/B/BSLock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include "RE/B/BSLock.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
4 changes: 2 additions & 2 deletions CommonLibSF/src/RE/M/Misc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace RE
void DebugNotification(const char* a_notification, const char* a_soundToPlay, bool a_cancelIfAlreadyQueued, bool a_arg4)
{
using func_t = decltype(&DebugNotification);
REL::Relocation<func_t> func{ REL::ID(138728) };
REL::Relocation<func_t> func{ Offset::Misc::DebugNotification };
return func(a_notification, a_soundToPlay, a_cancelIfAlreadyQueued, a_arg4);
}

Expand All @@ -14,7 +14,7 @@ namespace RE
std::uint32_t arg1 = 0;

using func_t = void(std::uint32_t&, const char*, const char*, float);
REL::Relocation<func_t> func{ REL::ID(167344) };
REL::Relocation<func_t> func{ Offset::Misc::PlayMenuSound };
return func(arg1, a_editorID, a_arg3, a_arg4);
}
}
1 change: 0 additions & 1 deletion CommonLibSF/src/RE/P/PlayerCamera.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include "RE/P/PlayerCamera.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/src/RE/P/PlayerCharacter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include "RE/P/PlayerCharacter.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/src/RE/T/TESObjectREFR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include "RE/T/TESObjectREFR.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down
1 change: 0 additions & 1 deletion CommonLibSF/src/RE/T/TESWorldSpace.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include "RE/T/TESWorldSpace.h"
#include "RE/Offsets.h"

namespace RE
{
Expand Down