feat: improve setting related classes #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't compile my test plugin by using your branch of Clib(it might be an issue on my end though as I usually overwrite include files and .lib file compiled from the latest branch) static_assert(sizeof(RegSettingCollection) == 0x160); is false |
ThirdEyeSqueegee
approved these changes
Oct 3, 2023
|
Regarding the Starfield.h thing, just a reminder that it isn't necessary to update Starfield.h in PRs--the maintenance workflow does that automatically when PRs are merged into main |
|
I have to do it if I want to test it, not for this specific instance but generally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.