Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add xmake ci #133

Merged
merged 8 commits into from
Oct 2, 2023
Merged

chore: add xmake ci #133

merged 8 commits into from
Oct 2, 2023

Conversation

qudix
Copy link
Contributor

@qudix qudix commented Oct 2, 2023

I had to comment out two includes (stdfloat and print) due to CI not using a newer version of the toolset (14.37) which includes these features.
https://en.cppreference.com/w/cpp/compiler_support/23

@FlayaN
Copy link
Contributor

FlayaN commented Oct 2, 2023

Not sure the issue is that the CI runners are missing the 14.37 toolset, it's that it's installed with 4 different toolset and in some cases it "picks" the wrong one.

For me using cmake I couldn't get it to build using msvc generator on the gh-workflow (It always picked the 14.35 instead of 14.37..), only worked using ninja generator.. Just if you wanted to look into it a bit more instead of commenting out the newest headers.

@qudix
Copy link
Contributor Author

qudix commented Oct 2, 2023

I can force it to choose 14.37, but then it will always use that. Commenting these two includes is the easiest since nothing in CLib uses the vast majority of the includes in PCH, including these two. I'm not even sure why they're all there.

@ThirdEyeSqueegee ThirdEyeSqueegee merged commit 3ebdb35 into main Oct 2, 2023
1 check passed
@ThirdEyeSqueegee ThirdEyeSqueegee deleted the feature/ci-xmake branch October 2, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants