Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: make plugin version return Version instead #129

Merged
merged 5 commits into from
Oct 1, 2023
Merged

feat!: make plugin version return Version instead #129

merged 5 commits into from
Oct 1, 2023

Conversation

qudix
Copy link
Contributor

@qudix qudix commented Oct 1, 2023

  • set default separator to .
  • simplify SetOrClearBit

@qudix qudix force-pushed the feat/version branch 3 times, most recently from cdb826d to d720a84 Compare October 1, 2023 03:24
@ThirdEyeSqueegee
Copy link
Member

Let's maybe remove the PluginVersion definition that takes a uint32 as well? As far as API is concerned it makes much more sense to just use Version for both getter and setter

@ThirdEyeSqueegee ThirdEyeSqueegee merged commit e4d1fcb into main Oct 1, 2023
3 checks passed
@ThirdEyeSqueegee ThirdEyeSqueegee deleted the feat/version branch October 1, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qudix @ThirdEyeSqueegee