feat: fix temporary implementation of IsPlayerCharacterInChargen() #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadeMe
reviewed
Sep 27, 2023
CommonLibSF/include/RE/A/Actor.h
Outdated
Comment on lines
30
to
39
| std::uint8_t flags = *(RE::stl::adjust_pointer<std::uint8_t>(PC, 0xF24)); | ||
|
|
||
| if (flags & 1 || flags & 2 || flags & 4) | ||
| { | ||
| return true; | ||
| } | ||
| else | ||
| { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I'd add a comment about this behaviour here and let someone else double-check if that's indeed what's happening. We shouldn't be making such changes willy-nilly at least until those flags are decoded.
There was a problem hiding this comment.
Sure. For anybody's information - prior to PR I tested flags by calling papyrus function SetInChargen(Bool abDisableSaving, Bool abDisableWaiting, Bool abShowControlsDisabledMessage) (29FAA60) with each argument and flags were set correctly by it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to what I assume is Bethesda bug after credit scene game assigns weird values to Chargen flags for the period of current gamesession. This fix will add a check for each flag separately and return the correct function result.