feat: Actor, AIProcess, ActorPackage RE
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like you forgot to move |
I was following how it was done in CommonLibF4, but sure I can separate them |
|
Maybe remove the empty .cpp files for now? Can always add them later when there's stuff to define |
powerof3
reviewed
Sep 27, 2023
qudix
previously requested changes
Sep 29, 2023
|
I will say that adding compilation units should be minimized where possible as they increase build times. The repo already contains a ton of empty files that aren't contributing anything and should be removed until they are actually required. edit: related pr |
Co-authored-by: Qudix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds AIProcess struct, the fields line up with CommonLibF4.