FHIRStore actor isolation
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jdisho
reviewed
Dec 23, 2024
There was a problem hiding this comment.
Awesome job @philippzagar ⚡️⚡️⚡️
Fyi, I left some suggestions. But these are more or less like nice-to-have ones.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 33.50% 34.97% +1.48%
==========================================
Files 21 21
Lines 1466 1467 +1
==========================================
+ Hits 491 513 +22
+ Misses 975 954 -21
Continue to review full report in Codecov by Sentry.
|
Supereg
requested changes
Dec 23, 2024
1 task
LeonNissen
approved these changes
Jan 6, 2025
Supereg
approved these changes
Jan 10, 2025
philippzagar
added a commit
that referenced
this pull request
Jan 28, 2025
# Write tests for `FHIRResource` and its extensions. ## ♻️ Current situation & Problem The `FHIRResource` class and its extensions currently have 0% test coverage. We should increase the code coverage as much as possible, to ensure long-term maintainability. ## ⚙️ Release Notes - This PR doesn't change any features. It adds tests for the `FHIRResource`, `FHIRResource+Search`, and `ResourceProxy+DisplayName`. - For the `FHIRResource+Category` tests, it's best to wait until PR #26 is merged into the main branch, avoiding any potential conflicts or inconsistencies. ## 📚 Documentation Comments are added throughout the code. ## ✅ Testing Aim for >90% code coverage, but >80% is acceptable in this case. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md). --------- Co-authored-by: Philipp Zagar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FHIRStoreactor isolation♻️ Current situation & Problem
As references in #25, the current
FHIRStoreimplementation is not ideal as it still uses preconcurrency locking mechanisms. Therefore, theFHIRStoreshould be reimplemented to use Swift's structured concurrency and isolation mechanisms.⚙️ Release Notes
FHIRStoreactor isolation with structured concurrency, not relying on locks anymore.FHIRResources are notSendableanymore (underlying ModelsR4 class is notSendable)📚 Documentation
Documented all isolation thoughts
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: