OTA 용 HotUpdater 인프라 #468
Open
OTA 용 HotUpdater 인프라 #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlpine
reviewed
Mar 9, 2025
Comment on lines
+5
to
+6
| domain_name = "scc-hot-updater-storage.s3.ap-northeast-2.amazonaws.com" | ||
| origin_id = "scc-hot-updater-storage" |
There was a problem hiding this comment.
이런거 aws_s3_bucket.prod_scc_hot_updater_storage.bucket_regional_domain_name 처럼 레퍼런스 형식으로 바꾸면 좋을듯
| lambda_function_association { | ||
| event_type = "viewer-request" | ||
| include_body = false | ||
| lambda_arn = "arn:aws:lambda:us-east-1:291889421067:function:hot-updater-edge:1" |
| resource "aws_iam_user" "hot_update_user" { | ||
| name = "hot-update-user" | ||
| tags = { | ||
| "AKIAUH5PXDMFXDWJFIHW" = "hot_updater_deploy" |
Comment on lines
+11
to
+14
| resource "aws_iam_user_policy_attachment" "hot_update_s3" { | ||
| user = aws_iam_user.hot_update_user.name | ||
| policy_arn = "arn:aws:iam::aws:policy/AmazonS3FullAccess" | ||
| } |
There was a problem hiding this comment.
이것도 모든 bucket 에 full access 주는것보다
아래처럼 policy document 를 만들어서 특정 resource 만 제한하는게 좋아보여요
data "aws_iam_policy_document" "scc_loki_storage_full_access" {
statement {
actions = [
"s3:*",
]
resources = [
aws_s3_bucket.scc_loki_storage.arn,
"${aws_s3_bucket.scc_loki_storage.arn}/*",
]
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO