Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[모니터링] trace 에 tail sampling 달기 #247

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

jyoo0515
Copy link
Member

  • trace 잘 나오는 것 확인 했고 (dev/scc-server) 헬스체크 trace 는 0.1 % 샘플링하도록 tail sampling 설정했습니다
  • 테섭 server 에서 조금 보다가 실섭에도 trace agent 붙이면 될 것 같습니다
  • 실섭에서 다른 api 도 sampling 이 필요하다 싶으면 추가하겠습니다
image

Checklist

  • 충분한 양의 자동화 테스트를 작성했는가?
    • 계단정복지도 서비스는 사이드 프로젝트로 진행되는 만큼 충분한 QA 없이 배포되는 경우가 많습니다. 따라서 자동화 테스트를 꼼꼼하게 작성하는 것이 서비스 품질을 유지하는 데 매우 중요합니다.

@jyoo0515 jyoo0515 requested a review from a team as a code owner March 25, 2024 14:18
},
},
{
# Rule 2: always sample if there is an error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋네요

@jyoo0515 jyoo0515 merged commit b2a8e86 into main Mar 28, 2024
1 check passed
@jyoo0515 jyoo0515 deleted the jason/20240325-filter-trace branch March 28, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants