feat(theme): add a toggle-theme keyboard shortcut - #718
Open
Marvelg256 wants to merge 1 commit into
Open
Conversation
Add a global keyboard shortcut (Ctrl+Shift+L / Cmd+Shift+L) to toggle between light and dark themes from any page. The shortcut is ignored while focus is inside editable elements (inputs, textareas, selects, contentEditable). Changes: - New ThemeShortcut component with global keydown listener - Added ThemeShortcut to AppShellExtras for global mounting - Documented shortcut in ShortcutsHelp and KeyboardShortcutsHelp - 20 unit tests covering toggling, editable-target exclusion, modifier variations, cleanup, and corrupted storage Closes StableRoute-Org#495
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a global keyboard shortcut (Ctrl+Shift+L / Cmd+Shift+L) to toggle between light and dark themes from any page. The shortcut is ignored while focus is inside editable elements (inputs, textareas, selects, contentEditable).
Changes:
Closes #495
Summary
Related Issue
Type Of Change
Testing
npm run lintnpm testnpm run buildContributor Checklist
type/area-slugwhere possible.Notes For Reviewers
💬 Join the StableRoute Discord for questions, reviews, and faster merges.