Add explicit empty and error states to the slippage view - #696
Merged
mikewheeleer merged 5 commits intoJul 30, 2026
Conversation
…ility to quote client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes #658
Pull Request Description
Title
feat(slippage): add empty and error statesDescription
This PR addresses missing empty and error states for the slippage indicator on the quote view (
/quote). It introduces a dedicatedSlippageViewcomponent with distinct states (empty,loading,error,success), complete with an accessible live region and a retry affordance when requests fail.Requirements & Changes Made
1. Distinct Component & States
empty: Indicates no quote or slippage data is present yet ("No slippage data").loading: Indicates quote/slippage calculation is in progress ("Calculating slippage…").error: Indicates an error occurred during quote retrieval, presenting the specific error message and a "Try again" button affordance.success: Displays the computed slippage percentage.2. Integration
SlippageViewinto the primary quote workflow, binding lifecycle state to the slippage component and providing aretryQuotecallback that re-executes the quote request on retry.3. Accessibility (WCAG 2.1 AA)
role="status"andaria-live="polite"regions so assistive technology dynamically announces state changes (loading → loaded, error states, and retry actions).Test Coverage & Test Output
Test File
Test Execution Output
Verification Steps
/quote.