refactor(types): centralize API response types#500
Merged
mikewheeleer merged 2 commits intoJul 23, 2026
Merged
Conversation
….ts with centralized API response type definitions (Pair, Quote, AppEvent, DisplayEvent, ApiKey, CreateApiKeyResponse, Webhook) - Update modules to import/re-export from types.ts for consistency: * src/lib/quote.ts re-exports Quote * src/lib/events.ts re-exports AppEvent, DisplayEvent * src/lib/webhookEvents.ts re-exports Webhook * src/app/pairs/pairsUtils.ts imports Pair - Update all Client components to import types from types.ts: * src/app/api-keys/Client.tsx uses ApiKey and CreateApiKeyResponse * src/app/webhooks/Client.tsx uses Webhook * src/app/quote/Client.tsx uses Quote * src/app/pairs/Client.tsx uses Pair (via pairsUtils) - Add comprehensive test suite with 42 tests covering: * All type definitions and their properties * Type constraints and edge cases * Re-exports from utility modules * Type interoperability and nesting - Update docs/api-client.md with centralized types documentation This eliminates type drift between pages and provides a single source of truth for API response shapes. Validation logic remains in respective modules (quote.ts, events.ts, webhookEvents.ts). Test coverage: 42/42 tests passing Lint: ✓ No warnings or errors Build: ✓ Production build succeeds
Contributor
|
thanks @darius-daniel, this is exactly what #351 needed. merging 🎊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate all API response type definitions into src/lib/types.ts
to prevent type drift and establish a single source of truth.
ApiKey, and Webhook types
Validation logic remains in respective modules (quote.ts, events.ts,
webhookEvents.ts) as domain owners.
Related Issue
Closes #351