feat(api-keys): add recently created keys section with visual distinction#322
Open
shinzoxD wants to merge 3 commits into
Open
feat(api-keys): add recently created keys section with visual distinction#322shinzoxD wants to merge 3 commits into
shinzoxD wants to merge 3 commits into
Conversation
…tion - Separate recently created keys (< 5 min or matching recentPrefix) into a highlighted section with emerald border and background - Keep existing keys in a separate section below - Mark the most recently created key with a 'New' badge - Add comprehensive tests for section separation and conditional rendering Fixes StableRoute-Org#314
…discriminated-union State<T> + refetch type caused TS2339 errors\nin pairs/Client.tsx and stats/Client.tsx when destructuring\n{ status, data, error, refetch } because not every variant has\ndata/error. Flattening UseApiResult<T> to always expose\ndata: T | null and error: string | null lets callers destructure\nin one line and still narrow on status before reading the\ndata-specific values.\n\nAlso adds && data / && status.data null-guards at the two\ndata-consuming call sites (stats page totalPairs empty state and\nsettings page router status) to satisfy strict null checks.
Author
|
@mikewheeleer — friendly ping on this fork PR (feat(api-keys): add recently created keys section with visual distinction).\n\nCI is currently failing on pre-existing main-branch test flakes ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #314
This PR adds a dedicated section for recently created API keys, making it easier for operators to spot new keys at a glance.
Changes
recentPrefixfrom the last creation) into a highlighted section with emerald border and background<section>elements with accessible headingsTest plan
npm test— new tests added for section separationnpm run lintGrantFox
Stellar payout wallet:
GBVHELLD2JE235Y2NGTDT3MWI3T65ON6SY4N6FBHYVDAQ5FZC2CP5QXH