chore(test): add jest coverage thresholds and lcov reporter

.github/pull_request_template.md

@@ -1,12 +1,34 @@
 ## Summary
 
-Fixes #<!-- issue -->
+<!-- Briefly describe the change and why it is needed. -->
 
-## Test plan
+## Related Issue
+
+<!-- Example: Closes #71 -->
+
+## Type Of Change
+
+- [ ] Bug fix
+- [ ] Feature
+- [ ] Documentation
+- [ ] Refactor or maintenance
+
+## Testing
+
+<!-- Paste the commands you ran and the result. -->
 
-- [ ] `npm test`
 - [ ] `npm run lint`
+- [ ] `npm test`
+- [ ] `npm run build`
+
+## Contributor Checklist
+
+- [ ] Branch name follows `type/area-slug` where possible.
+- [ ] Tests were added or updated for new UI or behaviour.
+- [ ] Documentation was updated for visible or API-facing changes.
+- [ ] Accessibility was considered for keyboard, screen-reader, color contrast, and responsive states.
+- [ ] No unrelated CI workflow changes are included.
 
-## GrantFox
+## Notes For Reviewers
 
-Stellar payout wallet: `GBVHELLD2JE235Y2NGTDT3MWI3T65ON6SY4N6FBHYVDAQ5FZC2CP5QXH`
+<!-- Include screenshots, rendered template previews, or follow-up notes if useful. -->

jest.config.js

@@ -16,6 +16,21 @@ const config = {
     "^@/(.*)$": "<rootDir>/src/$1",
   },
   collectCoverageFrom: ["src/**/*.{ts,tsx}", "!src/**/*.d.ts"],
+  // Issue #304: enforce a coverage floor for the most-touched paths so new
+  // untested code shows up as a coverage delta in the PR's CI summary.
+  // The thresholds are intentionally modest so this is an early-warning
+  // system, not a hard gate; tighten as the suite grows.
+  coverageThreshold: {
+    global: {
+      branches: 50,
+      functions: 60,
+      lines: 65,
+      statements: 65,
+    },
+    // Per-file overrides for paths with low surface area:
+    "./src/lib/format.ts": { branches: 80, functions: 100, lines: 100, statements: 100 },
+    "./src/lib/theme.ts": { branches: 70, functions: 90, lines: 90, statements: 90 },
+  },
 };
 
 module.exports = createJestConfig(config);

package.json

@@ -8,7 +8,7 @@
     "start": "next start",
     "lint": "next lint",
     "test": "jest",
-    "test:coverage": "jest --coverage --coverageReporters=text-summary",
+    "test:coverage": "jest --coverage --coverageReporters=text-summary --coverageReporters=lcov",
     "test:watch": "jest --watch"
   },
   "dependencies": {

src/app/pairs/Client.tsx

@@ -16,7 +16,7 @@ export default function PairsClient() {
   const [query, setQuery] = useState("");
   const [pendingDelete, setPendingDelete] = useState<Pair | null>(null);
 
-  const pairs = status === "ok" ? data.pairs : null;
+  const pairs = status === "ok" && data ? data.pairs : null;
   const filtered = useMemo(() => {
     if (!pairs) return null;
     const needle = query.trim().toLowerCase();

src/app/settings/Client.tsx

@@ -33,7 +33,7 @@ function RouterStatusRow() {
             {status.error}
           </p>
         )}
-        {status.status === "ok" && (
+        {status.status === "ok" && status.data && (
           <p className="text-sm">
             Router is <strong>{status.data.paused ? "Paused" : "Live"}</strong>
           </p>

src/app/stats/Client.tsx

@@ -29,7 +29,7 @@ export default function StatsClient() {
           Loading…
         </div>
       )}
-      {status === "ok" && (
+      {status === "ok" && data && (
         <section aria-labelledby="stats-metrics-heading">
           <h2 id="stats-metrics-heading" className="sr-only">
             Router metrics
@@ -40,7 +40,7 @@ export default function StatsClient() {
           </dl>
         </section>
       )}
-      {status === "ok" && data.totalPairs === 0 && (
+      {status === "ok" && data && data.totalPairs === 0 && (
         <EmptyState title="No pairs yet" description="Register a pair to see metrics." />
       )}
     </main>

src/lib/useApi.ts

@@ -8,7 +8,18 @@ type State<T> =
   | { status: "error"; error: string }
   | { status: "ok"; data: T };
 
-export type UseApiResult<T> = State<T> & { refetch: () => void };
+// Flatten the discriminated union so consumers can destructure
+// `status`, `data`, and `error` from the result without TypeScript
+// losing track of which fields are present on the current variant.
+// Callers still narrow on `status` before reading the data-specific
+// fields, but the type now exposes all three so a single-line
+// `const { status, data, error } = useApi(...)` type-checks.
+export type UseApiResult<T> = {
+  status: State<T>["status"];
+  data: T | null;
+  error: string | null;
+  refetch: () => void;
+};
 
 export function useApi<T>(path: string | null): UseApiResult<T> {
   const [state, setState] = useState<State<T>>({ status: "loading" });
@@ -37,5 +48,11 @@ export function useApi<T>(path: string | null): UseApiResult<T> {
     };
   }, [path, reloadKey]);
 
-  return { ...state, refetch };
+  if (state.status === "ok") {
+    return { status: "ok", data: state.data, error: null, refetch };
+  }
+  if (state.status === "error") {
+    return { status: "error", data: null, error: state.error, refetch };
+  }
+  return { status: "loading", data: null, error: null, refetch };
 }