feat(config): add read-only global config view - #437
Merged
mikewheeleer merged 1 commit intoJul 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
GlobalConfigandget_global_config(), a read-only view aggregating the contract's global (non-pair-scoped) configuration — fee recipient, absolute fee ceiling/floor, oracle, and timelock delay — into a single call instead of five separate getters. Every field returns its existing documented sane default, so the view is safe to call pre-init.Includes tests for: pre-init defaults, values after configuration, and that the view is side-effect free.
Test output
maincurrently fails to build at HEAD with ~100 pre-existing, unrelated errors (duplicatetop_up_pair_liquiditydefinitions from a prior merge — confirmed viagit stashthat this reproduces with zero local changes). This is out of scope for this PR. I verified the new code adds zero additional errors viacargo build --tests 2>&1 | grep -i global_config(no matches) and manually reviewed the newGlobalConfig/get_global_configcode against the existing getter patterns it mirrors.Closes #409