Support powershell/bash/fish shell - #5
Merged
Conversation
…ly resolving binary path via Get-Command ApplicationType, preventing function self-calling; remove return exit_code as powershell functions output return values to pipeline causing unwanted stdout pollution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds shell support for bash, fish and powershell. Previously only zsh was supported. Also fixes shell history detection to automatically read from the correct history file based on the active shell.
Type of change
How to test?
npm install -g zap-searchzap init bash >> ~/.bashrc && source ~/.bashrczap init fish >> ~/.config/fish/config.fishzap init powershell >> $PROFILE && . $PROFILEzap <pattern>— should cd into selected folderzap web <cmd>— should write selected command to promptzap %<pattern>— should show history commands matching patternChecklist
npm run build)