-
Notifications
You must be signed in to change notification settings - Fork 1
feat: 양식 업로드시, pdf일 경우와 이미지일 경우의 로직 분기 #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthrough이번 변경에서는 파일 업로드 서비스의 PDF 처리 기능이 추가되고, S3 URL 파싱의 견고성이 개선되었습니다. PDF 파일은 이미지로 변환 후 업로드되며, 지원하지 않는 파일 유형과 잘못된 S3 URL에 대한 예외가 새로 도입되었습니다. 개발 환경 설정과 에러 코드도 일부 변경되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant FormServiceImpl
participant PdfService
participant S3Service
Client->>FormServiceImpl: uploadForm(file)
alt file is PDF
FormServiceImpl->>PdfService: convertPdfToImage(pdfBytes)
PdfService->>S3Service: uploadImageBytes(fileName, imageBytes)
S3Service-->>PdfService: S3 image URL
PdfService-->>FormServiceImpl: S3 image URL
FormServiceImpl->>S3Service: extractKeyFromUrl(imageUrl)
S3Service-->>FormServiceImpl: S3 key
else file is jpg/png
FormServiceImpl->>S3Service: upload(file)
S3Service-->>FormServiceImpl: S3 image URL
else unsupported file
FormServiceImpl-->>Client: throw UnsupportedFileTypeException
end
FormServiceImpl-->>Client: return uploaded image URL
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (10)
💤 Files with no reviewable changes (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🔍 관련 이슈
✅ 작업 분류
✨ 작업 내용
✅ 체크리스트
Summary by CodeRabbit