Add specific error class for 503s #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've also cleaned up the use of `last_response` versus `@last_response`.
bittersweet
force-pushed
the
add_503_status
branch
from
c8a662c to
48aa400
Compare
|
Thanks for checking 👍 I've Rebased because of #14 , merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also cleaned up the use of
last_responseversus@last_response.The list of errors is growing, now to add one you have to make a class, a constant, and add it to the case statement. Not sure how to improve that as some of them do have some custom logic for some statuses.
If we have a custom status for 503, it's easier to ignore that specific error in our error logging if wanted.