Raise error if Help Scout returns validation errors #1
Conversation
lib/help_scout.rb
Outdated
There was a problem hiding this comment.
You can also define this inside the HelpScout class, I think I've seen it be done like that more often.
There was a problem hiding this comment.
Ah thought that was only possible inside a Module, but seems to be working 👍
bittersweet
left a comment
bittersweet
left a comment
There was a problem hiding this comment.
Looks good, great improvement. There are some stylistic comments you might want to take a look at implementing.
lib/help_scout.rb
Outdated
There was a problem hiding this comment.
I think it would be nice for readability to extract these status codes into constants, I always forget what they are, or at least I have to think a bit for non 200/403/404 etc.
lib/help_scout.rb
Outdated
There was a problem hiding this comment.
What about raising a catch all type thing here at the end if the response is not one of 201 or 400? I'm not super sure what kind of statuses they return at the moment though.
lib/help_scout.rb
Outdated
There was a problem hiding this comment.
I think we normally do raise ErrorClass.new(message) but fine either way.
dennispaagman
force-pushed
the
raise_error_on_validation_fail
branch
from
331fb38 to
ce6c17a
Compare
|
🚢 |
We sometimes send borked data to Help Scout, leading to validation errors on their side. They return these nicely, unfortunately the gem currently assumes success (such an optimist) and gives a non descriptive:
Because of a missing
locationheader. This adds a check on the status code of the response and raises aHelpScout::ValidationErrorexception with the actual error message returned from HS.