Implementation Code Cleanup #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion to clean up some compiler warnings. Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
|
nice, there's a few little things here that could be nice to include #23 |
ST-DDT
reviewed
Jun 6, 2018
| @@ -1007,7 +1007,7 @@ public static EntityItem entityOnDropItem(Entity entity, ItemStack itemStack, fl | |||
| * @param offsetY The offset y coordinate | |||
| * @return The item entity | |||
| */ | |||
| @SuppressWarnings({"unchecked", "rawType"}) | |||
| @SuppressWarnings({"unchecked", "rawType", "rawtypes"}) | |||
There was a problem hiding this comment.
Isnt the old rawType a typo and thus can be removed?
| * @param random The random instance | ||
| * @return The motion vector | ||
| */ | ||
| @SuppressWarnings("unused") |
There was a problem hiding this comment.
Item pre-merging will be reintroduced, just not right now.
Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
phit
reviewed
Jun 6, 2018
| .buildAndSwitch()) { | ||
| handler.getTimingsHandler().startTimingIfSync(); | ||
| .buildAndSwitch(); | ||
| final Timing timings = handler.getTimingsHandler()) { |
There was a problem hiding this comment.
Same as here, note how it lines up with CauseStackManager
There was a problem hiding this comment.
I guess he referred to it being 5 spaces instead of 4 or 8. IIRC 8 is a common standard for this. Aligning it as it is here is also used but less common. As always: styles are just personal preferences.
phit
reviewed
Jun 6, 2018
| @@ -411,16 +414,18 @@ private boolean post(Event event, List<RegisteredListener<?>> handlers) { | |||
| try (CauseStackManager.StackFrame frame = Sponge.getCauseStackManager().pushCauseFrame(); | |||
| final PhaseContext<?> context = PluginPhase.Listener.GENERAL_LISTENER.createPhaseContext() | |||
There was a problem hiding this comment.
That's the proper indentation since it's a multiple try with resources.
…sed as necessary. Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall code cleanup for a bunch of compiler warnings. This is a WIP and of course, the cleanup is intended only for cleanup, no actual functionality changes.
This should improve however some corner cases that can occur as nullability and validation checks can be better written for certain areas of code.