Skip to content

Commit

Permalink
Fix some OCD issues
Browse files Browse the repository at this point in the history
ref #23
  • Loading branch information
kashike committed Nov 29, 2016
1 parent d9259e3 commit e1ac12e
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 8 deletions.
2 changes: 1 addition & 1 deletion SpongeAPI
Submodule SpongeAPI updated 83 files
+1 −0 checkstyle-suppressions.xml
+2 −1 src/main/java/org/spongepowered/api/GameRegistry.java
+1 −1 src/main/java/org/spongepowered/api/block/tileentity/carrier/Chest.java
+4 −4 src/main/java/org/spongepowered/api/command/CommandCallable.java
+5 −5 src/main/java/org/spongepowered/api/command/CommandManager.java
+2 −2 src/main/java/org/spongepowered/api/command/CommandMapping.java
+1 −1 src/main/java/org/spongepowered/api/command/args/CommandContext.java
+2 −2 src/main/java/org/spongepowered/api/command/args/CommandFlags.java
+5 −5 src/main/java/org/spongepowered/api/command/spec/CommandSpec.java
+2 −2 src/main/java/org/spongepowered/api/config/ConfigManager.java
+3 −3 src/main/java/org/spongepowered/api/config/ConfigRoot.java
+1 −1 src/main/java/org/spongepowered/api/data/DataTransactionResult.java
+1 −1 src/main/java/org/spongepowered/api/data/ImmutableDataHolder.java
+4 −4 src/main/java/org/spongepowered/api/data/Property.java
+1 −1 src/main/java/org/spongepowered/api/data/key/Keys.java
+3 −2 src/main/java/org/spongepowered/api/data/persistence/AbstractDataBuilder.java
+1 −1 src/main/java/org/spongepowered/api/data/property/AbstractProperty.java
+2 −2 src/main/java/org/spongepowered/api/data/property/LocationBasePropertyHolder.java
+1 −5 src/main/java/org/spongepowered/api/entity/Entity.java
+2 −2 src/main/java/org/spongepowered/api/entity/Equipable.java
+2 −1 src/main/java/org/spongepowered/api/event/Event.java
+4 −4 src/main/java/org/spongepowered/api/event/command/SendCommandEvent.java
+3 −3 src/main/java/org/spongepowered/api/event/command/TabCompleteEvent.java
+2 −2 src/main/java/org/spongepowered/api/event/entity/ChangeEntityExperienceEvent.java
+1 −1 src/main/java/org/spongepowered/api/event/message/MessageChannelEvent.java
+7 −7 src/main/java/org/spongepowered/api/event/network/ClientConnectionEvent.java
+5 −5 src/main/java/org/spongepowered/api/item/Enchantment.java
+1 −1 src/main/java/org/spongepowered/api/item/ItemType.java
+3 −3 src/main/java/org/spongepowered/api/item/inventory/Inventory.java
+1 −1 src/main/java/org/spongepowered/api/item/inventory/ItemStack.java
+1 −1 src/main/java/org/spongepowered/api/item/inventory/Slot.java
+4 −4 src/main/java/org/spongepowered/api/item/inventory/entity/PlayerInventory.java
+12 −12 src/main/java/org/spongepowered/api/item/inventory/equipment/EquipmentInventory.java
+1 −1 src/main/java/org/spongepowered/api/item/inventory/property/AbstractInventoryProperty.java
+8 −3 src/main/java/org/spongepowered/api/item/inventory/property/InventoryDimension.java
+1 −1 src/main/java/org/spongepowered/api/item/inventory/property/MappedIntProperty.java
+3 −3 src/main/java/org/spongepowered/api/item/inventory/property/SlotPos.java
+2 −2 src/main/java/org/spongepowered/api/item/inventory/slot/SidedSlot.java
+1 −1 src/main/java/org/spongepowered/api/item/inventory/transaction/InventoryTransactionResult.java
+8 −8 src/main/java/org/spongepowered/api/item/inventory/type/GridInventory.java
+1 −1 src/main/java/org/spongepowered/api/item/inventory/type/Interactable.java
+6 −6 src/main/java/org/spongepowered/api/item/inventory/type/Inventory2D.java
+6 −6 src/main/java/org/spongepowered/api/item/inventory/type/OrderedInventory.java
+2 −2 src/main/java/org/spongepowered/api/item/merchant/TradeOffer.java
+1 −1 src/main/java/org/spongepowered/api/network/ChannelBinding.java
+1 −1 src/main/java/org/spongepowered/api/plugin/PluginManager.java
+1 −1 src/main/java/org/spongepowered/api/service/ProvisioningException.java
+2 −3 src/main/java/org/spongepowered/api/service/context/Context.java
+26 −0 src/main/java/org/spongepowered/api/service/context/package-info.java
+1 −1 src/main/java/org/spongepowered/api/service/economy/transaction/TransactionResult.java
+8 −8 src/main/java/org/spongepowered/api/service/pagination/PaginationList.java
+1 −1 src/main/java/org/spongepowered/api/service/pagination/PaginationService.java
+26 −0 src/main/java/org/spongepowered/api/service/pagination/package-info.java
+1 −1 src/main/java/org/spongepowered/api/service/permission/MemorySubjectData.java
+1 −1 src/main/java/org/spongepowered/api/service/permission/PermissionDescription.java
+1 −1 src/main/java/org/spongepowered/api/service/permission/PermissionService.java
+2 −2 src/main/java/org/spongepowered/api/service/permission/Subject.java
+1 −1 src/main/java/org/spongepowered/api/service/permission/SubjectCollection.java
+3 −3 src/main/java/org/spongepowered/api/service/permission/SubjectData.java
+2 −2 src/main/java/org/spongepowered/api/service/permission/option/OptionSubjectData.java
+26 −0 src/main/java/org/spongepowered/api/service/rcon/package-info.java
+26 −0 src/main/java/org/spongepowered/api/service/user/package-info.java
+1 −1 src/main/java/org/spongepowered/api/text/channel/MessageReceiver.java
+1 −1 src/main/java/org/spongepowered/api/text/format/TextStyle.java
+1 −1 src/main/java/org/spongepowered/api/util/Functional.java
+1 −1 src/main/java/org/spongepowered/api/util/SpongeApiTranslationHelper.java
+1 −1 src/main/java/org/spongepowered/api/util/ban/Ban.java
+2 −2 src/main/java/org/spongepowered/api/util/blockray/BlockRay.java
+2 −2 src/main/java/org/spongepowered/api/util/generator/event/factory/ClassGenerator.java
+1 −1 src/main/java/org/spongepowered/api/util/generator/event/factory/ClassGeneratorProvider.java
+2 −2 src/main/java/org/spongepowered/api/util/generator/event/factory/FactoryProvider.java
+1 −1 src/main/java/org/spongepowered/api/world/Chunk.java
+1 −1 src/main/java/org/spongepowered/api/world/Dimension.java
+13 −13 src/main/java/org/spongepowered/api/world/Location.java
+1 −1 src/main/java/org/spongepowered/api/world/PortalAgent.java
+6 −6 src/main/java/org/spongepowered/api/world/World.java
+16 −16 src/main/java/org/spongepowered/api/world/WorldBorder.java
+2 −2 src/main/java/org/spongepowered/api/world/biome/BiomeType.java
+1 −1 src/main/java/org/spongepowered/api/world/extent/BiomeVolume.java
+4 −4 src/main/java/org/spongepowered/api/world/extent/BlockVolume.java
+2 −2 src/main/java/org/spongepowered/api/world/extent/Extent.java
+1 −1 src/main/java/org/spongepowered/api/world/extent/TileEntityVolume.java
+9 −9 src/main/java/org/spongepowered/api/world/storage/WorldProperties.java
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ private static CommandSpec getBlockInfoCommand() {
final RayTraceResult rayTraceResult = EntityUtil.rayTraceFromEntity(entityPlayerMP, 5, 1.0F);
if (rayTraceResult.typeOfHit != RayTraceResult.Type.BLOCK) {
src.sendMessage(Text.of(TextColors.RED, TextStyles.ITALIC,
"Failed to find an entity! Please execute the command when looking at an entity!"));
"Failed to find a block! Please execute the command when looking at a block!"));
return CommandResult.empty();
}
final WorldServer worldServer = (WorldServer) entityPlayerMP.world;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class CollisionModCategory extends ConfigCategory {

@Setting(value = "enabled", comment = "Set to false if you want mod to ignore entity collision rules.")
private boolean isEnabled = true;
@Setting(value = "defaults", comment = "Default max collisions used for all entities/blocks unless overidden.")
@Setting(value = "defaults", comment = "Default max collisions used for all entities/blocks unless overridden.")
private Map<String, Integer> defaultMaxCollisions = new HashMap<>();
@Setting(value = "blocks")
private Map<String, Integer> blockList = new HashMap<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class DebugCategory extends ConfigCategory {
@Setting(value = "dump-threads-on-warn", comment = "Dump the server thread on deadlock warning")
private boolean dumpThreadsOnWarn = false;

@Setting(value = "concurrent-entity-checks", comment = "Detect and prevent certain attempts to use entities concurrently.\nWARNING: May drastically decrase server performance. Only enable this to debug a pre-existing issue")
@Setting(value = "concurrent-entity-checks", comment = "Detect and prevent certain attempts to use entities concurrently.\nWARNING: May drastically decrease server performance. Only enable this to debug a pre-existing issue")
private boolean concurrentChecks = false;

public boolean doConcurrentChecks() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class EntityActivationRangeCategory extends ConfigCategory {

@Setting(value = "auto-populate", comment = "If enabled, newly discovered entities will be added to this config with a default value.")
private boolean autoPopulate = false;
@Setting(value = "defaults", comment = "Default activation ranges used for all entities unless overidden.")
@Setting(value = "defaults", comment = "Default activation ranges used for all entities unless overridden.")
private Map<String, Integer> defaultRanges = new HashMap<>();
@Setting(value = "mods", comment = "Per-mod overrides. Refer to the minecraft default mod for example.")
private Map<String, EntityActivationModCategory> modList = new HashMap<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public class EntityCollisionCategory extends ConfigCategory {
private boolean autoPopulate = false;
@Setting(value = "max-entities-within-aabb", comment = "Max amount of entities any given entity or block can collide with. This improves performance when there are more than 8 entities on top of eachother such as a 1x1 spawn pen. Set to 0 to disable.")
private int maxEntitiesWithinAABB = 8;
@Setting(value = "defaults", comment = "Default max collisions used for all entities/blocks unless overidden.")
@Setting(value = "defaults", comment = "Default max collisions used for all entities/blocks unless overridden.")
private Map<String, Integer> defaultMaxCollisions = new HashMap<>();
@Setting(value = "mods", comment = "Per-mod overrides. Refer to the minecraft default mod for example.")
private Map<String, CollisionModCategory> modList = new HashMap<>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public void initializeCollisionState(World worldObj) {

Integer entityMaxCollision = null;
if (this.mcEntity instanceof EntityItem) {
// check if all items are overidden
// check if all items are overridden
entityMaxCollision = collisionMod.getEntityList().get(this.spongeEntityType.getName());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import org.spongepowered.api.registry.ExtraClassCatalogRegistryModule;
import org.spongepowered.api.registry.RegistrationPhase;
import org.spongepowered.api.registry.RegistryModule;
import org.spongepowered.api.registry.RegistryModuleAlreadyRegisteredException;
import org.spongepowered.api.registry.util.PluginProvidedRegistryModule;
import org.spongepowered.api.registry.util.RegistrationDependency;
import org.spongepowered.api.resourcepack.ResourcePack;
Expand Down Expand Up @@ -102,6 +103,8 @@
import java.util.Set;
import java.util.function.Supplier;

import javax.annotation.Nullable;

@SuppressWarnings("deprecation")
@Singleton
public class SpongeGameRegistry implements GameRegistry {
Expand Down Expand Up @@ -148,7 +151,11 @@ public void preRegistryInit() {

@Override
public <T extends CatalogType> SpongeGameRegistry registerModule(Class<T> catalogClass, CatalogRegistryModule<T> registryModule) {
checkArgument(!this.catalogRegistryMap.containsKey(catalogClass), "Already registered a registry module!");
@Nullable final CatalogRegistryModule<T> existingModule = (CatalogRegistryModule<T>) this.catalogRegistryMap.get(catalogClass);
if (existingModule != null) {
throw new RegistryModuleAlreadyRegisteredException("Already registered a registry module!", existingModule);
}

this.catalogRegistryMap.put(catalogClass, registryModule);
if (this.phase != RegistrationPhase.PRE_REGISTRY) {
if (catalogClass.getName().contains("org.spongepowered.api") && catalogClass.getAnnotation(PluginProvidedRegistryModule.class) == null) {
Expand Down

0 comments on commit e1ac12e

Please sign in to comment.