Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface-based config support #412

Draft
wants to merge 36 commits into
base: trunk
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
f24998d
Initial work to support interface-based configs
Tim203 Jul 2, 2023
efcb213
Allow all tests to run properly
Tim203 Jul 3, 2023
b29d241
Split some classes and added Range annotations
Tim203 Jan 3, 2024
e4b7f7f
Added default value annotations and restructured tests
Tim203 Jan 3, 2024
948cebe
Allow setter return type to be non-void
Tim203 Jan 3, 2024
ba11369
Auto-generate simple mappings
Tim203 Jan 3, 2024
7f6059f
Added Hidden annotation and added Processor.AdvancedFactory to aid it
Tim203 Jan 5, 2024
78bcaf5
Added support for some build-in annotations and added another addProc…
Tim203 Jan 6, 2024
c8524c8
Started working on adding tests for interfaces runtime
Tim203 Jan 6, 2024
336de1c
Merge remote-tracking branch 'origin/master' into feature/interfaces
Tim203 Jan 6, 2024
6f23846
Use correct impl name for mappings
Tim203 Jan 6, 2024
f07dc2f
chore(build): Only set test flags on newer JDK versions
zml2008 Jan 7, 2024
6c7f27c
Add all annotations that support fields. Use messager for errors
Tim203 Jan 13, 2024
c009449
Made AnnotationDefaults easier to follow
Tim203 Jan 13, 2024
a9c0e2f
Added support for default getters and default setters
Tim203 Jan 14, 2024
e0d9d42
Notify users about Hidden limitation. Optimized Hidden constraint
Tim203 Jan 14, 2024
224e87c
Exit gracefully on failure
Tim203 Jan 14, 2024
b62cab5
Add support for Gradle incremental annotation processing
Tim203 Feb 1, 2024
2d89b9d
Added Field annotation
Tim203 Feb 11, 2024
40d1c07
Apply spotless
Tim203 Feb 11, 2024
ab13924
Applied forbiddenApi fixes
Tim203 Feb 11, 2024
c5533d5
Renamed error to printError to trick PMD
Tim203 Feb 11, 2024
e9c0dfc
spotlessApply
Tim203 Feb 11, 2024
ebed0c5
Fix pmdTest
Tim203 Feb 11, 2024
27786f0
Set core as api dependency
Tim203 Feb 12, 2024
2add4c9
Use superinterface instead of enclosed element
Tim203 Feb 12, 2024
c2dfc96
Set a default value for config sections
Tim203 Feb 12, 2024
1af436d
Update test
Tim203 Feb 12, 2024
7e45e31
Added serialization to InterfaceTypeSerializer
Tim203 Feb 13, 2024
6945a5d
Respect superclasses' declaration of Exclude
Camotoy May 26, 2024
edd0685
Friendly error if implementation name cannot be found
Camotoy May 26, 2024
4347700
Made it easier to use the interface's default options
Tim203 Jun 12, 2024
e79e4d8
Oops, it's the other way around woo
Tim203 Jun 12, 2024
31c63fd
Superclasses with ConfigSerializable define order
Camotoy Aug 21, 2024
7543cd4
Don't try to initialize ConfigSerializable if @Field is marked
Camotoy Aug 24, 2024
7b4769c
InterfaceDefaultOptions#addTo with ObjectMapper modification
Camotoy Sep 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(build): Only set test flags on newer JDK versions
J8 still fails to build locally, but with a different issue
zml2008 committed Jan 7, 2024

Verified

This commit was signed with the committer’s verified signature.
erikmd Erik Martin-Dorel
commit f07dc2f60caa8ad2c2eaabe613a0d3b6e57f9ba6
12 changes: 8 additions & 4 deletions extra/interface/ap/build.gradle
Original file line number Diff line number Diff line change
@@ -18,8 +18,12 @@ dependencies {
tasks.withType(Javadoc).configureEach { enabled = false }

tasks.withType(Test).configureEach {
// See: https://github.com/google/compile-testing/issues/222
jvmArgs '--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED'
jvmArgs '--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED'
jvmArgs '--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED'
doFirst {
// See: https://github.com/google/compile-testing/issues/222
if (javaLauncher.get().metadata.languageVersion >= JavaLanguageVersion.of(9)) {
jvmArgs '--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED'
jvmArgs '--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED'
jvmArgs '--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED'
}
}
}