Feat/phase1 finalization and qa gate#1
Merged
RichardHightower merged 6 commits intomainfrom Dec 18, 2025
Merged
Conversation
Finalize Doc-Serve Phase 1 by implementing core server functionality, CLI management tool, and monorepo orchestration. Establish a mandatory quality assurance protocol via 'task pr-qa-gate' and updated agent guidelines. Changes: - Complete doc-serve-server: document indexing, semantic search, and ChromaDB storage - Complete doc-svr-ctl: Click-based CLI with status, query, index, and reset commands - Establish Task-based monorepo automation with root and package-level Taskfiles - Implement PR QA Gate workflow for GitHub Actions and local execution - Fix CLI test import path issues to ensure full test suite passes - Update CLAUDE.md and AGENTS.md with mandatory QA gate requirements - Finalize Phase 1 specs and tasks documentation
- Implement stable ID generation for text chunks based on file path and index - Switch vector store to use upsert for idempotent indexing - Update QUICK_START.md and USER_GUIDE.md to focus on global CLI tools - Refactor monorepo structure to use proper package names (doc_serve_server) - Update SKILL.md for doc-serve to utilize CLI-based workflows - Fix all remaining import and test path issues
- Update pyproject.toml to use [tool.ruff.lint] instead of top-level select - Replace deprecated datetime.utcnow() with datetime.now(timezone.utc) - Clean up unused and duplicated imports in indexing_service.py
- Fix PR QA Gate workflow to use new package names for coverage - Update AGENTS.md and CLAUDE.md with correct paths and commands - Update doc-serve-server README.md architecture and examples - Update SDD with current project structure - Resolve all remaining references to the old 'src' directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new quality assurance workflow for pull requests and pushes, expands the Bash command allowlist, and adds a comprehensive analysis command specification for cross-artifact consistency checks. The main changes focus on improving automated code quality checks and enhancing artifact analysis capabilities.
CI/CD and QA Improvements:
.github/workflows/pr-qa-gate.yml) that runs on all pull requests and pushes tomainanddevelopbranches. This workflow checks out code, sets up Python and dependencies, runs linting, type checking, and tests (with coverage) for both the server and CLI, and uploads coverage reports to Codecov.Artifact Analysis Enhancements:
/speckit.analyze(.opencode/command/speckit.analyze.md), outlining a strict, read-only process to analyze and report on inconsistencies, ambiguities, duplications, and coverage gaps acrossspec.md,plan.md, andtasks.md, including constitution alignment and severity assignment.Bash Command Allowlist Updates:
.claude/settings.local.jsonto include additional scripts and binaries such asdoc-svr-ctl,doc-serve, Python executables, andkill, improving the flexibility and coverage of allowed commands.