Spicy Lyrics parses with AMLLs parser instead of the proprietary one. - #344
Open
unatried wants to merge 3 commits into
Open
Spicy Lyrics parses with AMLLs parser instead of the proprietary one.#344unatried wants to merge 3 commits into
unatried wants to merge 3 commits into
Conversation
…ly oss (i believe)
Author
Contributor
Greptile SummaryThe PR replaces server-side TTML parsing with the AMLL client parser and routes local and remotely supplied raw TTML through the new normalization path.
Confidence Score: 4/5The PR is not yet safe to merge because word-timed TTML with background vocals still fails parsing and is surfaced as missing lyrics. The undefined Files Needing Attention: src/utils/Lyrics/manager/parseTTML.ts
|
| Filename | Overview |
|---|---|
| src/utils/Lyrics/manager/parseTTML.ts | Replaces the server parser with AMLL conversion, but the previously reported undefined helper remains reachable for word-timed background vocals. |
| src/utils/Lyrics/manager/index.ts | Parses locally stored TTML in-browser and enriches the normalized result before tagging it as local. |
| src/utils/Lyrics/fetchLyrics.ts | Detects raw TTML network payloads, parses them locally, and preserves legacy object payload handling. |
| src/components/ReactComponents/LyricsManager/components/UploadTTMLModal.tsx | Adapts temporary uploads to consume the parser’s normalized object directly. |
| package.json | Adds the AMLL TTML parser runtime dependency. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Upload["Uploaded TTML"] --> Parse["ParseTTML / AMLL parser"]
Network["Packed network response"] --> Unpack["SLObjPack.unpack"]
Unpack -->|"raw TTML string"| Parse
Parse --> Normalize["Line or syllable normalization"]
Normalize --> Process["ProcessLyrics enrichment"]
Process --> Render["Shared lyrics renderer"]
Reviews (3): Last reviewed commit: "How do these things keep slipping out of..." | Re-trigger Greptile
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the title, I also formatted the project with
bun run fmtbut "I" only edited four or more (read 5.) files.bun addBtw this is for an even bigger thing