Add proof-of-concept vertical NowBar layout positions - #342
Open
handofhate wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThe PR expands the persisted NowBar position from left/right to a four-position cycle and adds top/bottom layout styling while retaining the left layout in compact mode.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. Position validation, compact-mode left-side enforcement, persisted-position restoration, and the new vertical layout selectors form a consistent reachable lifecycle without an established broken state.
|
| Filename | Overview |
|---|---|
| src/components/Utils/NowBar.ts | Adds validated four-position cycling and centralizes DOM class updates for the NowBar and page. |
| src/components/Utils/CompactMode.ts | Extends compact-mode cleanup so top and bottom classes are removed when forcing the existing left layout. |
| src/css/ContentBox.css | Implements vertical artwork placement and reserves corresponding vertical space for lyrics; no concrete blocking defect was established. |
| src/utils/uiState.ts | Expands the persisted NowBar position union to include top and bottom. |
| src/components/Pages/PageView.ts | Renames the position control tooltip to reflect the expanded four-position behavior. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
L[Left] --> T[Top]
T --> R[Right]
R --> B[Bottom]
B --> L
C[Compact or PIP mode] --> L
X[Exit compact mode] --> P[Restore persisted position]
Reviews (1): Last reviewed commit: "Add vertical NowBar layout positions" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds proof-of-concept top and bottom NowBar positions.
This expands the existing NowBar side preference from left/right to left/top/right/bottom and makes the existing position button cycle through all four layouts. The goal is to support portrait/narrow displays where artwork above or below the lyrics is more usable than left/right artwork.
Notes:
I’m opening this as a proof of concept because the main structure is there, but I expect you may want to adjust the final UI/spacing/progress-bar behavior to match the project’s preferred design.