Add BaseSpikeVectorExtension
#4189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelgarcia
reviewed
Dec 1, 2025
Comment on lines
-359
to
-360
| # this is a bad hack to differentiate in the child if the parents is dense or not. | ||
| self.neighbours_mask = None |
Member
There was a problem hiding this comment.
The comment was good to keep I think
samuelgarcia
reviewed
Dec 1, 2025
|
|
||
|
|
||
| class GatherToHdf5: | ||
| class GatherToZarr: |
samuelgarcia
reviewed
Dec 1, 2025
Member
|
I am ok with this but we should be maybe merge the 2 PCA classes. |
samuelgarcia
approved these changes
Dec 4, 2025
Member
|
cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new BaseExtension that centralizes a lot of funcionalitites for the extensions which compute an array based on spike vectors: