Skip to content

Conversation

@wesbz
Copy link

@wesbz wesbz commented Jan 9, 2022

Hi,
Thanks for the interesting work.
Allow me to suggest this change for two reasons:

  • Expressing SNR in dB cancels the doubt there might be between power SNR and RMS SNR.
  • When sampling an SNR, it feels to me like it makes more sense to uniformly sample from the log scale of the dB than on the linear range. This way you ensure that your low SNR have as much chances as your high SNR.

I hope it makes sens. I'd be glad to discuss further about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant