Non-attachment image downloading #23
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitherill
commented
May 22, 2025
| url = confluence.url + src if src.startswith("/") else src | ||
|
|
||
| # Use existing confluence session for other URLs | ||
| response = confluence._session.get(url) |
There was a problem hiding this comment.
Heads-up: if the session ends up having retrial enabled (there's a PR), this might be an overkill for the image downloading (in my case I had many 404/host name resolution errors). In this case it's better to use requests.get(), but it will lack the Atlassian auth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24
Added functionality:
assetsfolder is created in the output location../assets/<hash from base64 data>.<extension based on mime type>./assets/<hash from src value>.<extension based on mime type or URL>