feature: mira network integration with the current lux codebase#253
Merged
rparcus merged 8 commits intoMay 14, 2025
Merged
Conversation
rparcus
reviewed
Apr 17, 2025
|
|
||
| # ... existing code ... | ||
|
|
||
| config :lux, :api_keys, |
Collaborator
There was a problem hiding this comment.
Please add the config to runtime.exs
Collaborator
There was a problem hiding this comment.
Please also add dummy values to .envrc and similar files
rparcus
reviewed
Apr 17, 2025
| } | ||
|
|
||
| # Test a simple completion | ||
| case Mira.call("What is the capital of France?", [], config) do |
Collaborator
There was a problem hiding this comment.
Is this some integration test? If yes, please just add it under integration tests folder and let's use the IntegratioCase
Contributor
Author
There was a problem hiding this comment.
I have addressed the concerns in the last commit. Please review them; let me know if anything needs to be changed.
rparcus
reviewed
May 14, 2025
Signed-off-by: Robert Parcus <923630+rparcus@users.noreply.github.com>
Pull Request Test Coverage Report for Build 8249105d4c909ecdad4f0e3e046c0bdbf648771c-PR-253Details
💛 - Coveralls |
rparcus
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mira Network Integration
Overview
Integrated Mira Network as a new LLM provider in the Lux framework.
Features
Implementation Details
MIRA_API_KEY)Testing