Add WinPreventDirectoryDeletion option to prevent watched directory d… #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new Windows-specific option
WinPreventDirectoryDeletionthat allows users to prevent the watched directory from being deleted while being monitored.Motivation
By default, Windows file watcher uses
FILE_SHARE_DELETEflag when opening directory handles, which has two issues:Allows unwanted deletion: The watched directory can be deleted while monitoring is active, which can lead to unexpected behavior in applications that need to ensure the watched directory remains accessible throughout the monitoring period.
Missing delete events: When
FILE_SHARE_DELETEis enabled and the watched directory itself is deleted, the watcher may not receive a delete event for the directory. This makes it impossible to detect when the monitored directory has been removed.This option allows applications to:
Changes
Options::WinPreventDirectoryDeletionto controlFILE_SHARE_DELETEbehavior1, prevents directory deletion by excludingFILE_SHARE_DELETEfrom share mode0(default), maintains original behavior (allows deletion)Usage Example