Added TLS/startTLS support to LDAP authentication #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current LDAP integration does not support TLS/startTLS for ldap authentication. I have added the code to do so.
I am unable to determine if any changes need to be made to the code that parses the ldap_authorizations.xml file as the LDAP module is passed the configuration in its constructor.
From what I could trace it appears that an old version of spago-core 2.3.0 is used in SpagoBIUtils that contains the SourceBean class that loads the configuration. I cannot find this class in the master branch.
thanks