Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Member Matters to the provide an endpoint page #132

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

jabelone
Copy link
Contributor

@jabelone jabelone commented Apr 8, 2024

  • Added Member Matters to the provide an endpoint page
  • Added .DS_Store to .gitignore for macOS devs

An example instance can be seen on my makerspace's portal here for reference: https://portal.brisbanemaker.space/api/spacedirectory/

@rnestler rnestler changed the title Added Member Matters to the provide an endpoint page Add Member Matters to the provide an endpoint page Apr 12, 2024
@rnestler
Copy link
Member

@jabelone Can you rebase your branch? We had problems with the CI config, which should be fixed now.

@dbrgn
Copy link
Contributor

dbrgn commented Apr 12, 2024

Regarding the .DS_STORE commit, I'm not a fan of that, since this is something that should typically be added to your user- or system-wide gitignore instead because it is specific to your operating system. You can find the location of your systemwide gitignore with git config --get core.excludesfile. I'd be fine with adding it to our .gitignore though since it doesn't hurt either.

Additionally, the filename is actually wrong, it should be .DS_Store. All-uppercase only works because macOS has a case-insensitive file system by default, but it won't match the file if the file system is case sensitive.

It would be great if you could either update or remove that commit.

@jabelone
Copy link
Contributor Author

@rnestler and @dbrgn I have updated and rebased. Thanks!

@rnestler rnestler requested a review from dbrgn April 26, 2024 09:14
Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like for somebody else of the SpacaAPI team to approve as well.

@rnestler rnestler requested a review from a team April 26, 2024 09:17
Copy link
Contributor

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbrgn dbrgn merged commit 97824bd into SpaceApi:master Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants